Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix client secret keyref value key in readme #253

Merged
merged 2 commits into from
Oct 14, 2024
Merged

fix client secret keyref value key in readme #253

merged 2 commits into from
Oct 14, 2024

Conversation

psych0d0g
Copy link
Contributor

Description

Just an update to the readme to document the correct key names for existing clientsecret values from pre-existing secret

@github-actions GitHub Actions
Copy link

github-actions bot commented Oct 13, 2024 •
edited
Loading

CLA Assistant Lite bot All contributors have signed the CLA ✍️ ✅

@psych0d0g
Copy link
Contributor Author

I have read and understood the CLA and hereby agree to its terms by making this Pull Request Comment.

@amitlicht
Copy link
Contributor

Thanks for your fix @psych0d0g! 🦦
This also needs fixing in https://github.com/otterize/docs/blob/main/docs/reference/network-mapper/helm-chart.mdx, let me know if you'd like to take care of that or I will 🙏

@amitlicht amitlicht self-requested a review October 14, 2024 07:32
@amitlicht
Copy link
Contributor

@psych0d0g I noticed the failing E2E CI tests on your PR, they seem related to this issue dorny/test-reporter#149.
I'm on it.

@amitlicht amitlicht mentioned this pull request Oct 14, 2024
Merged
1 task
@psych0d0g psych0d0g mentioned this pull request Oct 14, 2024
Merged
@amitlicht
Copy link
Contributor

@psych0d0g could you please pull the latest https://github.com/otterize/helm-charts main into your fork? Hopefully this commit: 9fc35a8 solves the CI issues

@amitlicht
Copy link
Contributor

I see it's still failing. I'll merge your PR despite the failures (it's only failing to report the test results, the tests themselves are fine), and will follow this up at a later time.

@amitlicht amitlicht merged commit 3e8038d into otterize:main Oct 14, 2024
6 of 8 checks passed
@github-actions github-actions bot locked and limited conversation to collaborators Oct 14, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@amitlicht amitlicht Awaiting requested review from amitlicht

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@psych0d0g @amitlicht